ps2dev / ps2sdk

Homebrew PS2 SDK
Other
896 stars 132 forks source link

Misalignment workaround for bdmfs_fatfs #593

Closed uyjulian closed 2 months ago

Ziemas commented 2 months ago

Does fatfs flush on every store? Would it make a performance difference to split out the unaligned part of the write in fs_write?

uyjulian commented 2 months ago

I think fatfs flushes when sector buffer is filled, but not sure about this.

I haven't messed with splitting fs_write calls.

fjtrujy commented 2 months ago

I think we shouldn't merge this, as the misalignment is just happening in the USB, no in all the units as is implementation does. Anyway, we should find a better solution here, as this is super slow... Let's wait if some other come with a different solution to the issue.

uyjulian commented 2 months ago

Closed in favor of https://github.com/ps2dev/ps2sdk/pull/599