Closed fjtrujy closed 5 months ago
Ping @AKuHAK @grimdoomer, @Ziemas, @JoseAaronLopezGarcia , and @davidgfnet as they could be interested in reviewing it too.
I saw two typos in the comments, other than that the code cleanup is great.
I saw two typos in the comments, other than that the code cleanup is great.
Thanks for the review, have in mind that majority of the changes are just to much the exactly original code content, in this way we will suffer less conflicts when applying updates on the library. I actually think that these typos are fixed by the owner in the next release
I saw two typos in the comments, other than that the code cleanup is great.
Thanks for the review, have in mind that majority of the changes are just to much the exactly original code content, in this way we will suffer less conflicts when applying updates on the library. I actually think that these typos are fixed by the owner in the next release
Alright it makes sense, yeah for now leave it exactly how the author has it.
Description
The main scope of this PR is to have better control over the changes we are doing over the FatFS dependency. I have created this FatFS repo which basically contains one commit per release of FatFs done. Additionally, I have created a separate branch,
iop-r0.14b
where I have applied currentps2sdk
changes there to visually see better what are custom changes done by our needs in one single commit.The majority of the changes that this PR has are related to code style (to match the original code), additionally some other tiny improvements have been done:
bdmfs_fatfs
now compiles wit-Werror
FF_FS_MBR
flag to disableMBR
on thefind_volume
function (more info here) in this way we keep current logic in a cleaner wayffsystem.c
for semaphoresWaitSema
I plan to do more PRs about FatFS in the incoming days, to upgrade to the latest version and maybe other improvements.
Cheers