search

ps2homebrew / hdl-dump

Install games in HDLoader format to APA-formatted hard drive
123 stars 25 forks source link

Clean commandline options and references to network #46

Open bignaux opened 2 years ago

bignaux commented 2 years ago

Pull Request checklist

Note: these are not necessarily requirements

Pull Request description

bignaux commented 2 years ago

A little cleaning before the release!

AKuHAK commented 2 years ago

mmm, are you sure that this should be removed? Some people still use hdl_srv_093.elf for installing. NBD isn't an option for MacOS users for example

bignaux commented 2 years ago

They can still use old release, that what they did anyway, still using old 093 exe. i just would like a massive cleanup on this tool, and i start by where this created confusion for users (as for example, poweroff is not available on nbd). Some people don't want to move forward, that shouldn't slow down others.

candidates for deletion: net_io.h hio_udpnet.c hio_udpnet.h hio_udpnet2.c hio_udpnet2.h net_common.c net_common.h

EDIT: Part of the point of writing lwNBD was also to simplify this tool to make it easier to maintain. By reducing the code coverage, it also simplifies refactoring and test coverage of the code...

bignaux commented 2 years ago

is directory execli something relevant in 2022 ?

AKuHAK commented 2 years ago

I still dont think that cutting off network is not a good idea, specially comparing with current speed in nbd implementation. Currently hdl_dump with srvr 0.9.3 is the fastest way to transfer. I never managed to use execli, probably it were used for debugging. As for cutting of features, probably the best is to cut various strange debug functions, like hio trace, hio dbg. Also stripping down various disk image format suport, like cdrwin, nero, etc, keeping only bin/cue and iso (and maybe direct

bignaux commented 2 years ago

I still think NBD would triumph over his conccurent and hdl_dump would benefit from stripped sources. In the stat of the project, i often ask myself if it worth the time spent and we don't have many contributors wanted to ride old kind of source. I prefer try time to time pushing, remember that no release means no release support in linux distrib, no life visibility on forum / news. i won't fight. For example, for populating large zeroed partition for linux and so, if i implement CMD_WRITE_ZEROES, lwnbd would be more efficient, on such task. Usage matter, letting old release and old server be the norm doesn't help here.

bignaux commented 2 years ago

Like the rest, I am never followed on my stuff. I'd close that PR.