ps2homebrew / hdl-dump

Install games in HDLoader format to APA-formatted hard drive
122 stars 25 forks source link

[ISSUE]: bgcol values from MC icon.sys are incorrectly converted #72

Open mrjaredbeta opened 1 year ago

mrjaredbeta commented 1 year ago

Checks

Describe the issue

Hdl_dumx wrongly converts the bgcol values in memory card binary format of icon.sys to HDDOSD text format. All four bgcol values are incorrectly divided to half of their actual value, resulting in background colors half as dull. The result is very ugly and bland because of this. The correct value should be 0-255 RGB color, but current tools limit this to 0-127. This could be that the documentation here is wrong, or that the MC format works a bit differently than in HDDOSD. Manually changing the bgcol values to the correct ones and injecting the header via hdl_dump works and shows fine in HDDOSD and looks 1:1 to the memory card icon colors. The rest of the parameter conversion seems to be correct.

Console model

SCPH-50001