ps2homebrew / wLaunchELF

ELF loader and File browser for Sony PlayStation 2
Other
500 stars 51 forks source link

Various changes #39

Closed uyjulian closed 4 years ago

rickgaiser commented 4 years ago

Did you intend to include all those commits in this PR, or only the last one?

The .gitlab-ci.yml does not belong here for sure, and the newlib changes make it compile and run in PCSX2, but there's still issues with a real ps2, right?

AKuHAK commented 4 years ago

So is it safe to merge? All changes are bugless?

AKuHAK commented 4 years ago

And. I thought that we are using ps2dev:ps2dev docker inage

uyjulian commented 4 years ago

Don't merge yet

uyjulian commented 4 years ago

I tested it on my PS2, and it works fine

Jay-Jay-OPL commented 4 years ago

Just wanted to let you know that I've tested compiling uLE up to commit: 2452243 and though it runs okay when you launch it from a PS2 console, it fails to open the following item on the default menu: About uLE -- it simply crashes uLE when attempting to.

And when you run it again and browse to the path: MISC/ -- it will not open the directory.

I also compiled the ELF using an updated installation (currently as of today) of ps2dev to install ps2toolchain, ps2sdk, and etc.

I hope that helps...

UPDATE: It will also refuse to open: mass:/

uyjulian commented 4 years ago

Works for me…
Try this https://github.com/uyjulian/uLaunchELF/suites/837746017/artifacts/9419692

Jay-Jay-OPL commented 4 years ago

@uyjulian -- I just tested the one you linked to download. Still acts the same way.

Here are my steps: 1) I place this ELF file inside a folder I have on my USB Flash HDD: mass:/test/BOOT.ELF 2) ran the ELF file and when I attempt the things I reported above, it still fails for me.

P.S. I suspected perhaps the LAUNCHELF.CFG file next to it was the culprit, so I deleted it, and I tested it again, but noticed that it seems when I press a button, it's too sensitive -- it sort of flashes a screen and then reverts back to the screen I was first looking at. So I can't even see mass, it goes so fast that I can see it for a second, but then it reverts back same thing with MISC -- at the very least I can browse mc0 and mc1.

Plus when I attempt to select About uLE -- that seems to still crash the application, because it then becomes inoperable.

Plus even after trying to go into the SETTING to see if something I can change to fix the issue, it tends to freeze up on me.

Hopefully others can test this. I am using a SLIM SCPH-77001 V15 with an authentic DualShock 2 controller.

uyjulian commented 4 years ago

Fast input should be fixed.

https://github.com/uyjulian/uLaunchELF/suites/838792791/artifacts/9442240

Jay-Jay-OPL commented 4 years ago

Bingo! That fixed the issue I reported above.

Now I spot a new issue (sorry).

Under the uLE Startup Settings, if I select to change the Pad Mapping to: X : OK and O : CANCEL and then save my uLE settings. When I restart uLE, I see that it didn't change that setting.

Plus, when I check the LAUNCHELF.CFG file, I see it didn't change the line. Even though uLE indicated that it did save my settings. So I assume that it's not changing that line in the CFG file when attempting to change that setting.

I'll keep checking if more things are broken. -- That is why I like testing it from my flash drive than replacing my main BOOT file on my memory card. ;)

UPDATE:

It seems it actually never writes to the LAUNCHELF.CFG file (that is next to the ELF file). Though it does indicate on the uLE top menu that it does save it to that path, but it never writes to it.

I tested to add a Button Setting path (shortcut), and after doing that, I saved the uLE Settings, it did indicate that it did save, but when I restart uLE the path (shortcut) I created was gone -- so that means it did not save the setting to the file.

UPDATE 2:

Correction: Actually it did write the shortcut path to the CFG file, but for some odd reason, uLE is not reading the CFG file when it starts up -- or at least that part to fetch all the shortcuts -- to the best of my knowledge.

But the other bug about saving the Pad Mapping settings to the CFG file, it never changes the CFG file.

uyjulian commented 4 years ago

Fixed pad mapping.
https://github.com/uyjulian/uLaunchELF/suites/839146452/artifacts/9448830

uyjulian commented 4 years ago

Should be ready for merge

AKuHAK commented 4 years ago

ok, wLe into a new era.

Jay-Jay-OPL commented 4 years ago

Okay, I tested your above version and you were able to fix most of the issues, but there is still one more bug -- I sort of mentioned in my third update above, but here a better explanation.

uLE will read correctly the LAUNCHELF.CNF file if found here: mc0:/SYS-CONF/ and if you have altered some of your changes to it, it will save your changes and next time you open uLE it will respect your changes. So that works okay.

But, if you keep that CNF file next to the ELF file -- let's say in this directory: mass:/test/:

mass:/test/BOOT.ELF
mass:/test/LAUNCHELF.CNF

uLE will save your changes to that path, but it will NOT read it from there, it will simply ignore it.

I believe that is a bug, since older uLE versions would give that CNF file first priority and would read it if it was found near the ELF file.