ps2homebrew / wLaunchELF

ELF loader and File browser for Sony PlayStation 2
Other
500 stars 51 forks source link

[Don't merge] Use sio2man/padman from ps2sdk #41

Open uyjulian opened 4 years ago

uyjulian commented 4 years ago

Pull Request checklist

Note: these are not necessarily requirements

Pull Request description

Use sio2man/padman from ps2sdk

sp193 commented 4 years ago

I attempted this before. If you do this, then you will break compatibility with homebrew that:

This is a problem for LaunchELF's current design, as the IOP modules used within the UI are also the ones that exist when a piece of software is loaded.

uyjulian commented 4 years ago

I can probably add a IOP reboot with the old configuration before executing the ELF…

uyjulian commented 4 years ago

Added compatible reset functionality.

AKuHAK commented 3 years ago

Looks good to me. If I understand logic correctly, wLe itself will use modules from SDK. But when launching elf it will perform an additional reset which replicates the current wLe state. @uyjulian Just to be sure - now ELF launch will take a longer time (as the reset function isn't that fast)? Did it break launch arguments when launching the new ELF? Do you want to add something else in PR? It is already pretty old maybe you have new ideas?

uyjulian commented 3 years ago

I think I might attempt to move the module loading to before the screen is blanked, so the user knows that the IOP is reloading.

uyjulian commented 3 years ago

I moved the reboot location to before the screen is cleared, and added an additional message specifying that the IOP is being rebooted.

However, I don't have hardware or the environment setup right now to test this functionality, so please check it.

AKuHAK commented 3 years ago

@uyjulian console and pcsx2 just freeze after "Rebooting iop in compatibility mode."

uyjulian commented 3 years ago

It looks like a ps2sdk update may have caused the black screen issue… I may bisect it later

uyjulian commented 3 years ago

The issue has been found: https://github.com/ps2homebrew/wLaunchELF/pull/59

AKuHAK commented 3 years ago

The issue has been found: #59

However, this PR still produces a black screen.

uyjulian commented 3 years ago

Since I added backwards compatible RPC to sio2man and padman to ps2sdk, I removed the reboot code.

AKuHAK commented 3 years ago

dont know if we should try to fix ps2eth, or I just roll back github action to 1.3.0

uyjulian commented 3 years ago

I already submitted a PR to fix ps2eth.