ps2homebrew / wLaunchELF

ELF loader and File browser for Sony PlayStation 2
Other
491 stars 51 forks source link

genOpen: Check if memory card is formatted before attempting open #88

Closed F0bes closed 1 year ago

F0bes commented 1 year ago

Fixes a black screen on launch issue when an unformatted memory card is inserted. Reproducible on PCSX2.

Pull Request checklist

Note: these are not necessarily requirements

Pull Request description

Reproduce-able on hardware and on PCSX2. wLaunchELF checks for "related files" on multiple devices, including memory cards. On opens to unformatted memory cards, the IOP will stall, making the EE stuck forever. These changes check the status of the memory card, and if it is unformatted, skips trying to open a file on it.

These changes could possibly be instead, put into the fileXio / whatever memory card library instead of doing the check here. Suggestions and ideas are welcome.

I believe this happened during v4.40, the changelog states "-Merged in a new mcman module by jimmikaelkael, fixing the FTP server bug". Possibly fixing mcman itself would be a better solution?