ps2homebrew / wLaunchELF

ELF loader and File browser for Sony PlayStation 2
Other
515 stars 51 forks source link

HddManager: disable the expand option, since it causes corruption #92

Closed uyjulian closed 2 years ago

uyjulian commented 2 years ago

Pull Request checklist

Note: these are not necessarily requirements

Pull Request description

Disable the expand option; it doesn't work correctly and may cause corruption.
I believe this was already done in kHn LE fork.

israpps commented 2 years ago

@uyjulian since you mentioned krHACKen fork...

Could you check the changes he made to allow deletion and renaming of __ prefixed partitions?

there are some checks that negate this on ATAD itself...

Maybe remove those checks? or restrict them to __mbr solely?

uyjulian commented 2 years ago

@uyjulian since you mentioned krHACKen fork...

Could you check the changes he made to allow deletion and renaming of __ prefixed partitions?

there are some checks that negate this on ATAD itself...

Maybe remove those checks? or restrict them to __mbr solely?

Not in the scope of this PR

sp193 commented 2 years ago

Since the issue is not with LaunchELF itself, why not attempt to fix the logic in the PFS driver or APA driver? Is that not possible?

AKuHAK commented 2 years ago

Lgtm

israpps commented 2 years ago

@uyjulian since you mentioned krHACKen fork... Could you check the changes he made to allow deletion and renaming of __ prefixed partitions? there are some checks that negate this on ATAD itself... Maybe remove those checks? or restrict them to __mbr solely?

Not in the scope of this PR

I know, just telling you...

Maybe you can check it some day

If you do it before I find the place where the check is placed ofc🤣