search

ps3dev / ps3toolchain

A script to autobuild an open source toolchain for the PS3.
BSD 2-Clause "Simplified" License
280 stars 92 forks source link

adds macOS support #84

Closed bucanero closed 4 years ago

bucanero commented 5 years ago

Adds support for macOS Mojave (10.14.6)

After installing the required libs/tools using brew in a macOS Mojave environment, some of the check-dependencies scripts required a fix to validate the installation paths properly.

miigotu commented 4 years ago

Why are you adding licences and badges and build workflows in the same PR as a build fix for Mac?

bucanero commented 4 years ago

Why are you adding licences and badges and build workflows in the same PR as a build fix for Mac?

I totally forgot about this PR, it looks like I submitted it a long time ago. Now I did some updates on my master branch, and ended up here too.

miigotu commented 4 years ago

This is why you should not make PR's from your master branch =P

bucanero commented 4 years ago

yes, you're right, I'm still learning about these process details with Git. Feel free to remove or close if needed.

miigotu commented 4 years ago

If you can, please rebase, resolve conflicts, and separate unrelated changes into separate PR's

bucanero commented 4 years ago

If you can, please rebase, resolve conflicts, and separate unrelated changes into separate PR's

alright, I'll try to make a new PR, including only the changes to build on macOS. Hopefully I'll figure out how to do it properly with my git client.

bucanero commented 4 years ago

Moved to PR #88