Closed enyachoke closed 8 years ago
Your implementation looks great! What validator are you trying to use? required
?
Yeah am using the required validator I just can't understand why the field is invalid even though it has a value and the serialized object has a valid value too.
Fixed the issue - new Date()
was passing true to lodash's isEmpty
and isObject
. I added a special check for Date objects using _.isDate
in 742afbd5aec713cf04dd3ebeee21df607fe2e849. Let me know if that fixes it for you in 2.0.6. Thanks again for posting.
Am currently trying out react-serial-forms for a json-based form rendering component to replace an angular implementation (https://github.com/AMPATH/openmrs-angularFormentry.git) used in https://github.com/AMPATH/ng-amrs which has run into crippling performance issues components https://github.com/enyachoke/React-FormEntry. So far the rendering is super fast but I have run into a small issue extending the datetimepicker from https://jquense.github.io/react-widgets/docs/#/datetime-picker. It seems to work okay and the value in serialized object gets updated as expected but the required validation fails for some reason. Any ideas will really be appreciated am sure am missing something.All the other widgets work great. Keep up the good work.