psake / PowerShellBuild

Common build tasks for psake and Invoke-Build that build and test PowerShell modules
MIT License
134 stars 24 forks source link

Added Module parameter and an [IO.Path]::Combine() to Build-PSBuildUpdatableHelp #55

Closed IMJLA closed 2 years ago

IMJLA commented 2 years ago

Description

The Module parameter removes the dependency on the $ModuleName variable in the parent scope while maintaining the existing behavior of inheriting its value.

The LandingPagePath key in $cabParams now uses the [IO.Path]::Combine([string[]]) method rather than manual string concatenation

Related Issue

https://github.com/psake/PowerShellBuild/issues/54

Motivation and Context

This will make it easier to use Build-PSBuildUpdatableHelp in custom psake files or other contexts

How Has This Been Tested?

All 195 existing Pester tests passed

Also tested in a vacuum as demonstrated by the example in the Issue

Screenshots (if appropriate):

Types of changes

Checklist:

devblackops commented 2 years ago

Thanks @IMJLA!