Fix for CodeCoverage, Instruction and Line results were always 0.00

FLeven commented 2 years ago

My Build was not completing anymore since I activated the Code Coverage, until I removed "[Math]::Truncate" for the $perc VAR.

I am still able to set and change the threshold for the percentage required to for the build to pass, this should be the solution to the problem.

Motivation and Context

I want to use the code coverage for my projects

How Has This Been Tested?

I changed the code coverage threshold to fail and pass my builds, and finally the numbers compared as excepted.

Screenshots (if appropriate):

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.

FLeven commented 1 year ago

Any chance to get his fix on the psgallery ?

HeyItsGilbert commented 3 weeks ago

@FLeven I'm interested in this, but can you help me understand how it was failing before? Ideally I would want to reproduce the error to confirm the fix in different scenarios.

Which version of PowerShell were you using? In theory Truncate should just round down to the nearest whole number.

psake / PowerShellBuild