search

psalm / psalm-github-security-scan

Psalm Security Scanning for GitHub Actions
53 stars 17 forks source link

Fix GHCR access token and bump login-action version #5

Closed eroullit closed 1 year ago

eroullit commented 1 year ago

Hi everyone ! 👋

I have noticed that the watch workflow updating the action is failing to publish the docker image due to missing credentials.

The goal of this pull request is to address this issue by leveraging the GITHUB_TOKEN secret and updating the docker/login-action

weirdan commented 1 year ago

Let's see if it works.

weirdan commented 1 year ago

Nope, it failed with this error: https://github.com/psalm/psalm-github-security-scan/actions/runs/4205776938/jobs/7298346578#step:6:35

https://stackoverflow.com/questions/69014742/github-denied-permission-denied-write-package

eroullit commented 1 year ago

Hey @weirdan ! 👋

I have opened #8 to address the permission issue listed above.

weirdan commented 1 year ago

https://github.com/psalm/psalm-github-security-scan/actions/runs/4254245971/jobs/7400220587#step:6:34

Merged. Still no good 🤷‍♂️

eroullit commented 1 year ago

Hi @weirdan !

We are getting there. 😃 The last bit should be about modifying the GITHUB_TOKEN permissions on this repo to grant packages: write access #9.