search

psalm / psalm-plugin-laravel

A Psalm plugin for Laravel
MIT License
307 stars 72 forks source link

Fix tests on CI #215

Closed Nielsvanpach closed 2 years ago

Nielsvanpach commented 2 years ago

Still one tests fails on 8.0 and 8.1. I temporarily disabled it. The last part to get the CI green again, is the action running laravel-test.sh. I'm afraid I'm not really able to help with that.

mr-feek commented 2 years ago

Thanks for the pr, mind resolving conflicts?

Nielsvanpach commented 2 years ago

@mr-feek updated. Excluded some parts of the matrix. If this gets merged, we can try again on L9 compatibility.

mr-feek commented 2 years ago

@Nielsvanpach looks very close, but something seems up with test laravel projects that deps can't be installed?

Nielsvanpach commented 2 years ago

@Nielsvanpach looks very close, but something seems up with test laravel projects that deps can't be installed?

@mr-feek Laravel 9 was used, since it's the default and this package is not yet compatible. Let's use Laravel 8 in the tests for now. Apart from that action still failing, it seems ready to be merged. Not really any changes in this PR, only running a different suite of tests so everything failing now, was already failing. It just shows up in the CI.

mr-feek commented 2 years ago

ill merge this, thanks a lot for the PR!

The remaining laravel check is failing. what we need to do is update the baseline to ignore those errors for now.