search

psalm / psalm-plugin-laravel

A Psalm plugin for Laravel
MIT License
307 stars 72 forks source link

Add support for later versions of IDE helper #226

Closed ronb-lendesk closed 2 years ago

ronb-lendesk commented 2 years ago

Prior to this change, projects that used later versions (>=2.10) would have issues with compatibility if it's using this package. This change adds support for later versions of that IDE helper. It builds on a previous PR where the FakeModelsCommand class is switched based on the installed version of the later version for compatibility.

I'm sure I missed something so please let me know. :)

mr-feek commented 2 years ago

thanks so much for this! Let's see how the CI does

mr-feek commented 2 years ago

(githubs having a bit of an outage on actions, might be a bit) https://www.githubstatus.com/

ronb-lendesk commented 2 years ago

@mr-feek Looks like github is back up again. Do you need to restart the actions?

mr-feek commented 2 years ago

@ronb-lendesk I think github is still a bit behind, the jobs are still marked as queued and won't let me cancel them to resubmit

mr-feek commented 2 years ago

@ronb-lendesk want to try pushing an empty commit? These github actions seem to be in a bad state due to their outage. they are stuck queued and i can't cancel them

orklah commented 2 years ago

closing/reopening seemed to do the trick :)

mr-feek commented 2 years ago

@ronb-lendesk this looks great. 2 things left to do:

1) Fix phpcs issues 2) Update the baseline for the laravel tests.

Are you up for these tasks?

ronb-lendesk commented 2 years ago

@mr-feek Yup! I'll take a look within the next couple of days :)

ronb-lendesk commented 2 years ago

@mr-feek Updated the code w/ fixes. I ran the the two laravel & lumen tests + phpcs fixes. All looks good now.

mr-feek commented 2 years ago

Thanks a lot for the PR @ronb-lendesk -- I'm going to merge it to dev-master where hopefully people can test for the next week or so before cutting a new release!

ronb-lendesk commented 2 years ago

Thanks a lot for the PR @ronb-lendesk -- I'm going to merge it to dev-master where hopefully people can test for the next week or so before cutting a new release!

Woohoo! Amazing. Thanks @mr-feek.