search

psalm / psalm-plugin-laravel

A Psalm plugin for Laravel
MIT License
301 stars 71 forks source link

Rename method to get model's properties #248

Closed dkuzmenchuk closed 1 year ago

dkuzmenchuk commented 1 year ago

Fix for issue #247

alies-dev commented 1 year ago

@dkuzmenchuk Thanks a lot! How it will be difficult for you to write a test that will fail on previous code and passes on the new one? Thanks a aging!

dkuzmenchuk commented 1 year ago

@lptn I will try to find the best way to write a test for this fix.

I force-pushed a new version of this branch. I rebased it onto the actual master to fix the failed action on last version

dkuzmenchuk commented 1 year ago

@lptn I didn't think of anything better than to check if file models.stubphp contains strings like class <ModelName> extends \Eloquent for every non-abstract model. Please let me know if you have a better idea.