search

psalm / psalm-plugin-laravel

A Psalm plugin for Laravel
MIT License
301 stars 71 forks source link

Update dependencies, remove unused ones #252

Closed alies-dev closed 1 year ago

alies-dev commented 1 year ago

I found it was a difficult decision to drop old Laravel versions support. I just joined the team and trying to prepare this repo for Laravel 10, make this plugin compatible with Larastan. It seems like the repo don't have active and stable contributors, in such situations IMO it's better to drop old versions and simplify life for new potential contributors by reducing number of supported versions. This PR is just a small step on doing it.

What do you think about this direction? E.g. I don't see any reasons of supporting old Psalm versions as they may produce a bit different error messages what is bad for testing.The same for Laravel versions - if we support 9.x, I think we can bump minor Laravel versions e.g. every 1-2 months to support versions not older than 6 months (Laravel minor updates are safe nowadays, they fully comply SerVer 2.0). As result - we can utilize more @template and other advanced annotations that cormmunitity added to Laravel code. I theory these updates should simplify maintenance and life of contributors.

mr-feek commented 1 year ago

I'm up for limiting support by major release versions of this package, if you think that will make maintenance easier! My thought process before was to have master support all of Laravel's supported releases -- but I'm open to changing that.

alies-dev commented 1 year ago

@mr-feek we can also support one-two previous Laravel versions, but not on master branch

E.g. this is the current list of supported Laravel versions (supported by Laravel itself):

image

According this list, we can support:

I hope with such approach we can focus o the main what is very important in case of very limited human resources

mr-feek commented 1 year ago

According this list, we can support:

Laravel 9 on master Laravel 8 on special working branch (or even without branches) Laravel 10 experimental support on 3.x branch (currently blocked by ide-helper dependency :( ) I hope with such approach we can focus o the main what is very important in case of very limited human resources

Sounds good to me 👍

Laravel 8 is losing support in a few days, so we can probably skip worrying about that.