search

psalm / psalm-plugin-laravel

A Psalm plugin for Laravel
MIT License
307 stars 72 forks source link

Use `orchestra/testbench-core` as `testbench` should only be used for Package development #359

Closed crynobone closed 8 months ago

crynobone commented 1 year ago

In package development, orchestra/testbench should be added explicitly which then requires orchestra/workbench, orchestra/canvas etc which isn't useful for this package usage when used in Laravel project.

alies-dev commented 1 year ago

thank you, @crynobone ! I'll take a look into it soon, but firstly would like to understand why orchestra packages are not in dev requirements. It will take some time, but I'll do my best, thanks

crynobone commented 1 year ago

but firstly would like to understand why orchestra packages are not in dev requirements.

It is being used directly via the following class:

https://github.com/psalm/psalm-plugin-laravel/blob/edc45c0cd193c3e82c3503154a56cb581e4b1e20/src/Providers/ApplicationProvider.php#L11-L23

So changing to orchestra/testbench-core will be the most minimal changes to avoid loading requirements available via orchestra/testbench when using this package.

alies-dev commented 8 months ago

Great, thank you, @crynobone I see some issues caused updates on the trunk branch, but I'll fix them on my own.