psalm / psalm-plugin-phpunit

A PHPUnit plugin for Psalm
76 stars 33 forks source link

consider dropping support for phpunit < 8 in a major release #53

Open SignpostMarv opened 4 years ago

SignpostMarv commented 4 years ago

as per failures on: ~https://travis-ci.org/psalm/phpunit-psalm-plugin/jobs/647313805?utm_medium=notification&utm_source=github_status~ https://travis-ci.org/github/psalm/psalm-plugin-phpunit/jobs/647313805

ktomk commented 4 years ago

@SignpostMarv: If you don't mind can you check the link in you report? I don't get anything useful when I open it.

And per the title, did you mean "new" major release? In any case, I had problems to find out wich Phpunit version are to be supported by the plugin and also wondered if it may even there is a requirement of having different plugins per Phpunit version. So far I'm fine to not drop 7.5x support from all the releases from my end.

SignpostMarv commented 4 years ago

have updated the link.

as for "new", yeah- you wouldn't want to drop support for a phpunit version in a minor/patch release.