Psalm 5

[danog]

Btw you can cherry-pick https://github.com/psalm/psalm-plugin-symfony/pull/288/commits/7a1c3fd3ffc4e0db8a2c75714b0d0d61a5a33a48 to pull in my optimization fixes if you want to finish this PR, I won't have much time today to work on the PR :)

[danog]

Have some severe doubts about how you removed those taint tests, the problem here is that Psalm is not detecting the issue (false negative), not that it shouldn't detect it (false positive).

[seferov]

Btw you can cherry-pick 7a1c3fd to pull in my optimization fixes if you want to finish this PR, I won't have much time today to work on the PR :)

thank you very much! It seems the commit is reverting Immutable/Mutable Union types which IMO is a downgrade.

[seferov]

Have some severe doubts about how you removed those taint tests, the problem here is that Psalm is not detecting the issue (false negative), not that it shouldn't detect it (false positive).

Taint tests are not removed except one (not removed but commented out temporarily) which does not work correctly due to Psalm bug

[danog]

Yeah, there's a psalm bug in taint detection that should be fixed before merging this MR imo

[seferov]

fixes https://github.com/psalm/psalm-plugin-symfony/issues/285