Add humanmade/coding-standards + Fix coding style errors

[mcaskill]

While testing this library and its open pull requests, I noticed that a phpcs binary was missing (for the Composer script @cs-check).

Added

• Dependency on humanmade/coding-standards
• EditorConfig ruleset file
• PHPCS ruleset file

Changed

• Fixed errors and warnings raised by PHPCS.

[kkmuffme]

I think splitting it into multiple files at this point in time is a really bad idea, as it will break all forks of this. There are many pending PRs (and non-submitted PRs, since nobody is actively maintaining this repo it seems, e.g. I have a private fork that is psalm v5 ready) and by changing it to multiple files at this point in time will just make it more work to PR those.

[mcaskill]

Ok. I can revert that change.

Its unfortunate about your private fork, I just finished work on a feature branch to support Psalm v5 that I was about to propose as a follow up to this pull request 😆

I started a fork of my own where I integrated your pull requests on top of this one.

[kkmuffme]

I think someone should get in touch with the current maintainers by email, I think this should be abandoned and we ask orklah if we can move the successor of this plugin (with all PRs, v5 ready) into the psalm github namespace, as that is probably the best solution long term, to avoid things getting stuck by abandoning.

[mcaskill]

I've pitched your idea to to Joe Hoyle and Human Made (by email) and Orklah (by Symfony's Slack).

[mcaskill]

Reply from Orklah:

I have no objection to adding this project to the Psalm namespace. I don't have all permissions on it myself but if Human Made and Joe Hoyle are up for it, I'll bring the discussion to Matt and Bruce, I'm sure it will be a formality. I'm not sure what that entails about packagist namespace though. However, having this under Psalm's namespace doesn't mean it will automatically get better support, at least from our end. As you probably already know, our time is quite limited and we can't offer a lot more than visibility on the official Psalm's namespace — From private conversation, symfony.com/slack

[ntwb]

Hey,

Unsure what HMs stance on maintaining this project in the future, but I'm happy to help land a few of these PRs so a new release tagged and pushed out

[mcaskill]

Unsure hat HMs stance on maintaining this project in the future, but I'm happy to help land a few of these PRs so a new release tagged and pushed out

Hi @ntwb, thanks for your help.

[joehoyle]

@mcaskill @kkmuffme thanks for reaching out! First off, thanks for all the contributions! This project is not exactly "abandoned", but like "on the sidelines", as it's more of a my project rather than Human Made, company wide. As such, I only get intermittent chances to review and merge things, or improve things.

This plugin is still pretty Alpha stages, so we are not using it in "production" by any means. I'd be happy to add you as GitHub committers if that would help too.

I'll also raise the discussion of transferring to Psalm's org, if that's the preferred approach.

Also thank you @ntwb for helping out! Are you using this at all?

[ntwb]

Also thank you @ntwb for helping out! Are you using this at all?

Only using on side projects here, it's crazy if I run it on the the project I'm working on at HM, but maybe one day I can formally add it to the project 🤞🏼

[kkmuffme]

@joehoyle thanks for the great idea & base you created!

We have been using it (well, our forked version) for months on our company's codebase and it works great - pretty stable overall :-)

I think in terms of maintaining it long term, moving it to psalm would be the most beneficial - this ensures that it evolves alongside psalm and is accessible/maintainable as long as psalm is maintained, without the need for any other org/people, who are/might be restricted by their other projects.

Since the current release doesn't actually work anyway (only the master branch one does), I think we could move it now - and then directly release one last, working psalm v4 compatible version (testing the release process in the new org) This will then allow us to add all new features and release a v5 compatible version once v5 drops in a couple weeks.

If that's fine for you @joehoyle, please let me know, so we can get the transfer done next week.

[joehoyle]

@kkmuffme ok sounds good!

[joehoyle]

@kkmuffme @mcaskill ah I think I need permissions on psalm's org to create public repos, is what github is telling me.