psalm / psalm.dev

Has the source for psalm.dev
https://psalm.dev
MIT License
11 stars 15 forks source link

Exclude `ghostwriter/*` psalm-plugins #101

Closed ghostwriter closed 1 year ago

ghostwriter commented 1 year ago

I unintentionally broke the plugin ranking system.

My bad.

It's unfair to other authors.

I'm removing my plugins until there is a new implementation.

weirdan commented 1 year ago

The plugins there ordered by the number of downloads. Is there some (unfair in your opinion) reason why yours are downloaded more than others?

ghostwriter commented 1 year ago

I have a custom CI/CD setup on to run on all my repos and it's using that plugin in almost all my private and public projects.

ghostwriter commented 1 year ago

I'd like to add,

All of my use-cases are completely legitimate, CI is running on production code for my clients and my dev tools, however the download count does not reflect the real user download count as it does for other authors.

weirdan commented 1 year ago

however the download count does not reflect the real user download count

Pretty much all of those download numbers (as well as downloads for Psalm itself) are heavily skewed by CI servers.

ghostwriter commented 1 year ago

Oh… well, then I’ll leave it to you and your team to make the decision of reverting this patch if you choose.

I simply wanted to make sure I made my intentions clear before it was misinterpreted.