psambit9791 / jdsp

A Java Library for Digital Signal Processing
https://jdsp.dev
MIT License
247 stars 43 forks source link

Hilbert Transform gives incorrect outputs #2

Closed psambit9791 closed 4 years ago

psambit9791 commented 4 years ago

For signals which have large number of values close to 0, like a Gaussian pulse, the instantaneous phase is incorrect. Comparisons made against scipy.hilbert() and their method of calculating phase and frequency.

signal The signal for which the issue was identified

issue The issue as visualised

psambit9791 commented 4 years ago

There was an issue with the fillH() method in Hilbert class. Now rectified. Closed issue.