search

psanford / wormhole-william-mobile

End-to-end encrypted file transfer for Android and iOS. A Magic Wormhole Mobile client.
MIT License
165 stars 16 forks source link

Corrupt sends with v1.0.4 #15

Closed rboyer closed 2 years ago

rboyer commented 2 years ago

I was trying to use this Android tool to send a file to my Linux laptop and I'm pretty sure it's corrupting the transfer.

I have a 2,693,769 byte binary file (tgz file) that on the other side of the wormhole ends up with an extra 375 bytes of seeming garbage at the end. I tried slicing that suffix off and passing it to the Linux "file" command and it doesn't have a detected structure.

I'm wondering if there's a uninitialized buffer read or incorrectly sized buffer involved?

psanford commented 2 years ago

I was able to reproduce this by generating a file of that length. I'll take a closer look this evening.

psanford commented 2 years ago

I believe this should be fixed in 233058dc. If you are able, can you try manually installing this build to confirm that it fixes the issue for you? https://github.com/psanford/wormhole-william-mobile/releases/tag/v1.0.5rc1

rboyer commented 2 years ago

Works now on that previously bad file transfer

On Mon, Nov 8, 2021, 22:42 Peter Sanford @.***> wrote:

I believe this should be fixed in 233058d https://github.com/psanford/wormhole-william-mobile/commit/233058dc00222a1adab36429598edf5334d57be5. If you are able, can you try manually installing this build to confirm that it fixes the issue for you? https://github.com/psanford/wormhole-william-mobile/releases/tag/v1.0.5rc1

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/psanford/wormhole-william-mobile/issues/15#issuecomment-963812431, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAABGJ5GKBECK2DXWQ2GE53ULCRFBANCNFSM5HTUK5IA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

psanford commented 2 years ago

1.0.5 is now available on the Play Store with this fix.

Thanks again!