search

psanford / wormhole-william-mobile

End-to-end encrypted file transfer for Android and iOS. A Magic Wormhole Mobile client.
MIT License
165 stars 16 forks source link

Use official uri-scheme in qr code #32

Open jonas-w opened 1 year ago

jonas-w commented 1 year ago

If i see it correctly, you use another uri-scheme than and you asked for the uri-scheme to be standardized https://github.com/magic-wormhole/magic-wormhole-protocols/issues/3. And it got standardized in https://github.com/magic-wormhole/magic-wormhole-protocols/pull/21.

Is there a specific reason, that your uri is different than the standard?

psanford commented 1 year ago

We implemented ours before anything was agreed upon. I don't see much point in supporting the spec until there's other interoperable clients, specifically other clients that support reading qr codes.

piegamesde commented 1 year ago

It does not do proper QR code scanning (yet), but Warp already has a wormhole: URI scheme handler registered. So updating to the new scheme would already be beneficial.

jonas-w commented 1 year ago

Agreed @piegamesde, as Fina says it is a chicken-egg problem https://gitlab.gnome.org/World/warp/-/issues/22

psanford commented 1 year ago

I'm open to a PR for this.

vlasky commented 1 year ago

We implemented ours before anything was agreed upon. I don't see much point in supporting the spec until there's other interoperable clients, specifically other clients that support reading qr codes.

@psanford I'm using Rymdport which generates QR codes using the official wormhole-transfer: URI scheme.

When I try to read the QR code using Wormhole William 1.0.8 on Android, it fails because it doesn't recognise the URI. I would be grateful if you could release a new version of Wormhole William with support for the official wormhole-transfer: URI scheme.

psanford commented 1 year ago

Like I said, I'm open to taking a PR to support both formats here.