search

psanford / wormhole-william

End-to-end encrypted file transfer. A magic wormhole CLI and API in Go (golang).
MIT License
1.08k stars 55 forks source link

Fix send dir on Windows #16

Closed rixtox closed 4 years ago

psanford commented 4 years ago

Thanks for this pr, the change looks good.

I merged a couple of PRs ahead of yours and now there's a minor conflict. Would you mind rebasing this PR onto master?

I also enabled Windows in the github actions so we can get better os test coverage. Would you mind updating the test case to demonstrate the problem? I think it would be as simple as updating the existing TestWormholeDirectoryTransportSendRecvDirect to change the two directory entry paths to use filepath.Join:

"skyjacking/personalize.txt" => filepath.Join("skyjacking", "personalize.txt")
"skyjacking/bodice-Maytag.txt" => filepath.Join("skyjacking", "bodice-Maytag.txt")
rixtox commented 4 years ago

Rebased, and test updated

psanford commented 4 years ago

The commit Author field doesn't seem to be associated with your github account. Can fix that also?

rixtox commented 4 years ago

The commit Author field doesn't seem to be associated with your github account. Can fix that also?

fixed

psanford commented 4 years ago

Merged. Thanks again!