psanford / wormhole-william

End-to-end encrypted file transfer. A magic wormhole CLI and API in Go (golang).
MIT License
1.08k stars 55 forks source link

Move over to using urfave/cli #32

Closed Jacalz closed 3 years ago

Jacalz commented 3 years ago

Hi there. I wanted to practice implementing a cli using https://github.com/urfave/cli and used this project as a test just to get the ball rolling. I am creating this as a draft PR for the moment before I know if this is something that would be appreciated or not. If it is something that you think is good, then I will happily clean it up further. If not, you can just outright close it. I just want to be a happy citizen and not just throw away potentially good code :)

psanford commented 3 years ago

I don't think this would buy us anything. I've used urfave/cli for projects in the past and see very little functional difference between it and cobra. I chose to use cobra here because I think its used by more Go projects overall.

Jacalz commented 3 years ago

Sure thing. The biggest benefit is probably just that it cleans up go.sum a bunch 🤷‍♂️