sub string of searched strings are not getting highlighted

psankar / Find-Many-Strings

A Google Chrome extension to highlight many strings simultaneously in web pages.

Apache License 2.0

11 stars 3 forks source link

Open kvijesh opened 13 years ago

kvijesh commented 13 years ago

Steps to reproduce

search for "everyone" (without quotes)
search "one"
search "every"
search "eryo" (I know its a crude test case, but there can be scenarios with the long names for methods and classes used)

"eryo" - does not get highlighted.

Expected, it should get highlighted.

But try searching "very" it would highlight. I'm guessing its not highlighting by grouping two already highlighted sections.

psankar commented 13 years ago

Confirming the issue. I don't know of the cleanest solution possible atm.

kvijesh commented 13 years ago

Same is the case if I try highlighting an already highlighted section and non-highlighted section.

HelloWorld

search "hello" - will highlight fine search "helloworld" - no change

varunkumar commented 13 years ago

There are serious problems with the jQuery Highlighter plugin. It needs to be re-written if sophisticated features are to be added to this extension.

varunkumar commented 13 years ago

This is what is happening:

When you search for "Everyone", the highlight plug-in does DFS on DOM tree starting from document.body. If a match is found in the text node "Everyone", the plug-in surrounds it with a tag to highlight. Hence, it becomes an element node. EveryOne
Search of "Every". DFS will reach the new element node and it will go further into the text node "EveryOne" and now DOM will look like this: EveryOne. Every & One are two different text nodes now.
Next search can search full / part of texts - Every, One. Search query containing a part of "Every" & "One" will not be matched.

PS: Very sleepy now. Some parts of this explanation might not be clear. Ping me on @varunkumar. It can be solved by tweaking the DOM parsing.