search

pschanely / CrossHair

An analysis tool for Python that blurs the line between testing and type systems.
Other
1.04k stars 49 forks source link

External contract registration #160

Closed pschanely closed 2 years ago

pschanely commented 2 years ago

I created a draft pull request just to make it easier to give you some early feedback. I come from a pretty intensive code review culture - apologies in advance if it seems picky. A lot of it is just naming suggestions etc, but that kind of stuff is always better to get out of the way early. Finally, don't hesitate to push back on any suggestion of mine.

Oh my goodness. Github just ate ~5 of my comments so there's much less here than there should be. Will have to try a remember/rewrite them tomorrow!😭

lmontand commented 2 years ago

I created a draft pull request just to make it easier to give you some early feedback. I come from a pretty intensive code review culture - apologies in advance if it seems picky. A lot of it is just naming suggestions etc, but that kind of stuff is always better to get out of the way early. Finally, don't hesitate to push back on any suggestion of mine.

Perfect, I agree that early code review is a good idea and making a PR is the best way if discussing it! Being rigorous is a good thing! I have indeed been hesitating for many of the variable names, so your feedback on those is welcomed!