Adding option to specify device name

pschatzmann / ESP32-A2DP

A Simple ESP32 Bluetooth A2DP Library (to implement a Music Receiver or Sender) that supports Arduino, PlatformIO and Espressif IDF

Apache License 2.0

1.55k stars 261 forks source link

Closed jmsunseri closed 11 months ago

jmsunseri commented 11 months ago

addresses issue #456

pschatzmann commented 11 months ago

I rather think that the existing set_local_name() method is wrong. What exactly is your new method supposed to do ?

jmsunseri commented 11 months ago

I'm just setting the dev_name variable so that later on

case BT_APP_EVT_STACK_UP: {
            // set up device name 
            esp_bt_dev_set_device_name(dev_name);

it will get picked up.

the existing set_local_name method seems to do something else doesn't it?

pschatzmann commented 11 months ago

I think It is supposed to do exactly that: To provide the local name. So I rather have this bug corrected then to create a new method

jmsunseri commented 11 months ago

I don't mind that at all.

jmsunseri commented 11 months ago

That is the fastest github MR i have ever seen! Thank you!