search

pschatzmann / arduino-audiokit

Arduino ADF/Audiokit HAL (support for ESP32-A1S, AI-Thinker, LyraT for ES7148, ES7210, ES7243, ES8311, ES8347, ES8388, TAS5805M, AC101 audio chips)
GNU General Public License v3.0
157 stars 42 forks source link

No headphone output for AudioKit on LyraT 4.3 board #100

Closed youqi66 closed 1 year ago

youqi66 commented 1 year ago

I tried the examples for AudioKit on LyraT 4.3 board, no headphone output. Debug info shows HEDPHONE_DETECT=-1 even if head phone is plugged in. The cause of it lies in lyrat_v4_3.h.

Line 72: #define HEADPHONE_DETECT 19 Line 77: #define HEADPHONE_DETECT -1

Line 77 override the value of HEADPHONE_DETECT and set it to -1. After remote this line, the headphone output is correct.

pschatzmann commented 1 year ago

Thanks a lot for your contribution.

I assume that you are new to the process and it seems that something went wrong, because I did not get any pull request in my repository, but somehow it ended up in yours.

Just click on the 1 commit ahead link in your repository. Double check that you copy from your repository (on the right) to mine (on the left) and click the create button: This should create a request in my repository.

If you don't want to do this, I can pick up from here. But I think this simple change is a perfect opportunity to get acquainted to this process..

youqi66 commented 1 year ago

Phil, I just did what you recommend and the pull request should be there in your repository now. Please let me know if there is still issues. You are right. I am new to git contribution and and still learning. BTW, your audio library is awesome. Thanks for your hard work! My personal opinion is that IDF/ADF is not easy to work with using VSC+IDF extension IDE. I could not get the examples working  with Lyrat board except that mp3 playing one. The error message is vague. Getting esp32 boards working with vast existing arduino libraries is a big plus I believe. On Wednesday, August 16, 2023 at 02:33:24 AM EDT, Phil Schatzmann @.***> wrote:

Thanks a lot for your contribution.

I assume that you are new to the process and it seems that something went wrong, because I did not get any pull request in my repository, but somehow it ended up in yours.

Just click on the 1 commit ahead link in your repository. Double check that you copy from your repository (on the right) to mine (on the left) and click the create button: This should create a request in my repository.

If you don't want to do this, I can pick up from here. But I think this simple change is a perfect way to exercise.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state.Message ID: @.***>

pschatzmann commented 1 year ago

Pull request has been completed. Thanks a lot