pschatzmann / logic-analyzer

Arduino Logic Analyzer API supporting the SUMP protocol (for sigrok, pulseview)
GNU General Public License v3.0
107 stars 15 forks source link

Use `GPIO_IN_ADDRESS` instead of `GPIO_OUT_ADDRESS` when reading on `ESP8266` #11

Closed cheif closed 1 year ago

cheif commented 1 year ago

After debugging and reading up on GPIO_* I realized that we're unintentionally using GPOI_OUT_ADDRESS here (intended for writing to pins), and just changed that to GPIO_IN_ADDRESS.

I think this has been here from the start, couldn't find any change where this line was touched at least, so I guess it hasn't ever worked, but now it works somehow at least. I still get pretty frequent crashes after/during captures, but now it's at least (barely) usable.

Should fix #10