search

pschiffe / docker-pdns

Docker images for PowerDNS
MIT License
274 stars 81 forks source link

Added possibility to use an existing config file for recursor or auth… #135

Closed murphy83 closed 6 months ago

murphy83 commented 6 months ago

Idea to have the option to use an already existing (eg. externally generated) config file for recursor or authorative power-dns-mysql). The behavior is controlled by setting the environment variable USE_EXISTING_CONFIG_FILE to "true". Disabled by default.

pschiffe commented 6 months ago

Hello @murphy83 , thank you for your contribution. I'm OK with this change, however, could you update also the pdns-pgsql image, so both images (pdns-pgsql and pdns-mysql) are equal feature-wise? Thank you.

murphy83 commented 6 months ago

I was thinking about this idea already, however I am still not 100% sure about the path to follow, as usually refrain from "just duplicating code". So I am a bit tempted to use something like a functions-file to include for the parts that are valid for both Postgres and MySQL/MariaDB. Let me know what you think fits better in your opinion.

pschiffe commented 6 months ago

Feel free to do what you prefer. I've kept it separate as it's really not that much code, it's fairly simple and not updated that often.

murphy83 commented 6 months ago

OK I think I will set to work on this in the evening.

murphy83 commented 6 months ago

Indeed ... this function was defined but never called ...