search

pschlan / cron-job.org

cron-job.org Open Source project
GNU General Public License v2.0
1.45k stars 251 forks source link

Add vietnamese language #121

Open dungphanxuan opened 2 years ago

dungphanxuan commented 2 years ago

Done 90%

dungphanxuan commented 1 year ago

@pschlan I have updated the Vietnamese language and added Japanese and Korean languages, please see the changes and help me merge the code

ShimadaNanaki commented 1 year ago

@dungphanxuan @pschlan I'm creating my repository in Japanese one right now, should I stop editing once I'm done? I'm Japanese and I'm trying my best not to use a translator, so I think it'll take a long time...

dungphanxuan commented 1 year ago

@B4kedBr3ad Hi, I found that using Google translate, the content is correct over 90%. Not much semantic error, You can refer to it first and then edit the content for the meaning, so it saves a lot of time.

ShimadaNanaki commented 1 year ago

@B4kedBr3ad Hi, I found that using Google translate, the content is correct over 90%. Not much semantic error, You can refer to it first and then edit the content for the meaning, so it saves a lot of time.

Not90%, it's 50%

pschlan commented 1 year ago

Thanks for this, will review/merge ASAP!

dungphanxuan commented 1 year ago

Hi @B4kedBr3ad I have this api/languages/ja.php (Copy from file api/languages/ja.php) file I want to translate into Japanese language. Can you help, thank you

ShimadaNanaki commented 1 year ago

There are quite a few things that need to be corrected in Japanese, so we think it would be better to push once and then correct them. What do you think? @dungphanxuan @pschlan

pschlan commented 1 year ago

There are quite a few things that need to be corrected in Japanese, so we think it would be better to push once and then correct them. What do you think? @dungphanxuan @pschlan

I would prefer to merge this to the main branch only when it is in good shape. Until then, we can keep it in a branch / PR. Another idea would be to have separate PRs for the different languages - might make it easier to merge the finished ones early.

ShimadaNanaki commented 1 year ago

Okay, let's split it up by language.