search

pschmitt / roombapy

Python program and library to control Wi-Fi enabled iRobot Roombas
MIT License
32 stars 23 forks source link

roombapy does not work with hostnames #93

Open indagitto opened 3 years ago

indagitto commented 3 years ago

When trying to use roombapy, with hostnames (e.g. Roomba-BLID.domain or iRobot-BLID.domain) instead of IP address the commands have different results:

The same commands and same roomba device are working when using an IP address, tested on two different devices. Name resolution works and can ping via hostname (I've tested everything on the same machine, which is a Win10 with Python 3.9).

I assume this is intended or a limitation in the code, would it be possible to:

  1. Implement queries by hostname (preferred), or
  2. Ensure with a regex to accept only IP formats
Orhideous commented 7 months ago

roombapy discover 192.168.88.NNN works, roombapy discover iRobot-NNNNNNN.lan doesn't.