v1.7.1: if device can't be contacted, return off values instead of 'Not Responding'

pschroeder89 / homebridge-levoit-humidifiers

Levoit Humidifiers Plugin for Apple HomeKit via Homebridge

Apache License 2.0

70 stars 9 forks source link

v1.7.1: if device can't be contacted, return off values instead of 'Not Responding' #26

Closed pschroeder89 closed 2 years ago

pschroeder89 commented 2 years ago

Fixes:

If device can't be contacted (disconnected from wifi, unplugged, etc.), return off values instead of Not Responding. Error message will display in HomeBridge logs when attempting to read / write values to device.

smockle commented 2 years ago

@pschroeder89 Out of curiosity, are there any known issues which prevent this from being merged?

pschroeder89 commented 2 years ago

Hey @smockle, I actually want to put this behind a config value and turned off by default. IMO, HomeKit should know when a device is unresponsive. So if users want to turn that off for this plugin, they'll need to update the config.

Sorry this has gotten stagnant, I meant to get to it a while back. I should have this updated tonight and will get it merged. Thanks for the reminder!