Apache Commons HTTP-Client 3.1 dependancy when not allowing embedded stylesheets

[GoogleCodeExporter]

When allowing inline styles but not embedded stylesheets, this dependency is 
still required but does not need to be. Since CssScanner.java still imports it 
despite it never actually being used.

I suggest refactoring the code to use a subclass of CssScanner.java (e.g. 
ExternalCssScanner.java) which will require the dependency and is only created 
when the embedded stylesheet directive is enabled.

I have attached a patch of my proposed change.

Thanks.

Original issue reported on code.google.com by Scoo...@gmail.com on 19 Jul 2011 at 1:41

Attachments:

• antisamy-refactor.patch

[GoogleCodeExporter]

After some review, I put this patch into HEAD. I don't have a test case since I 
figure the problem could manifest with JVM-specific symptoms. If you can verify 
HEAD, that would be great.

Original comment by arshan.d...@gmail.com on 14 Sep 2011 at 8:58

• Changed state: Started

[GoogleCodeExporter]

I have to move forward with release, so feel free to re-open if you find the 
patch wasn't integrated successfully.

Original comment by arshan.d...@gmail.com on 15 Sep 2011 at 8:16

• Changed state: Fixed