Dwim params

[rabbiveesh]

I redid the part of the parameter processing to be (IMO) more readable and also allow for more user friendly parsing of parameters. The code is heavily commented and all the new features are covered with tests.

[coveralls]

Pull Request Test Coverage Report for Build 81

• 16 of 34 (47.06%) changed or added relevant lines in 1 file are covered.
• 3 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-2.03%) to 80.723%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/WebService/GoogleAPI/Client.pm	16	34	47.06%
<!--	Total:	16	34	47.06%	-->

Files with Coverage Reduction	New Missed Lines	%
lib/WebService/GoogleAPI/Client.pm	3	77.57%
<!--	Total:	3		-->

Totals
Change from base Build 79:	-2.03%
Covered Lines:	335
Relevant Lines:	415

---

💛 - Coveralls

[pscott-au]

Nice work Veesh - some of the specific examples to the variations in the Google Spec may change over time so we should try to keep an eye on that and update docs etc if the situation changes but this doesn't introduce any functional risks. The cleanup is well-considered and the comments are good. I will review more thoroughly but don't see any reason not to accept this merge straight away. I think I'll aim for a CPAN release over the weekend including your code. Let me know if you want write access to the repo or cpan release.

[rabbiveesh]

Could I get write access on both?

On Fri, Dec 14, 2018, 6:08 AM Peter Scott <notifications@github.com wrote:

Nice work Veesh - some of the specific examples to the variations in the Google Spec may change over time so we should try to keep an eye on that and update docs etc if the situation changes but this doesn't introduce any functional risks. The cleanup is well-considered and the comments are good. I will review more thoroughly but don't see any reason not to accept this merge straight away. I think I'll aim for a CPAN release over the weekend including your code. Let me know if you want write access to the repo or cpan release.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pscott-au/WebService-GoogleAPI-Client/pull/13#issuecomment-447207075, or mute the thread https://github.com/notifications/unsubscribe-auth/AWkXqjkNQF9TgpK2bRj_VbQaFDmqbG2Aks5u4yRagaJpZM4ZSSDI .