Create a server / client architecture

pscott commented 3 years ago

This is a useful bonus for the taskmaster project.

I think we could use the daemonize crate for that purpose :)

Ant0wan commented 3 years ago

Yep

pscott commented 3 years ago

Reopening because we reverted the PR.

pscott commented 3 years ago

Closed by #11

Ant0wan commented 3 years ago

I will push to add daemonize function to taskmasterd.

pscott commented 3 years ago

I will push to add daemonize function to taskmasterd.

I don't think we need it. It works pretty well right now without using any other crate. Any particular reason you want to use daemonize?

Ant0wan commented 3 years ago

In our case we are not daemonizing the process. We keep hanging the tty and we are bound to the user SID. In order for it to be a proper daemon, we need:

to call umask to change it for 027 or 077 depending on what we want to achieve,
to fork the process and exit parent to garantee process is not seesion leader and it is a prerequiste for calling setsid
to call setsid to create new session -> mmakes it process leader of new session and process group and is disassociated from its controlling terminal
it changes working directory of process
it closes unneeded file descriptors
dup fds to log file daemonize() allows taskmasterd to do so. I think it is important. What do you think ?

pscott commented 3 years ago

@Ant0wan You're right, this would bring in bonus points (and would make it a lot cleaner). Thanks for explaining! :D Will review the PR ASAP :)

pscott / TaskMaster

Create a server / client architecture #7