Week 2: NYTimes - Ready for Review

[psdewar2]

My app is complete with most user stories, please review. /cc @codepathreview @codepath

[codepathreview]

Good job overall! A few notes after checking out the assignment:

• Properly reused the single base method in search activity to fetch results for both initial load and the pagination
• Nice to see you added the search box to the ActionBar!
• Good job using the ConnectivityManager to check for network availability
• Properly used Spinners and Check-Boxes (with populated values) to allow users to select appropriate values.
• Properly sent and received relevant filters using a bundle to pass data between activities
• One thing to consider is rather than sending and returning all the filter values separately as keys, might have introduced a parcelable model (i.e SearchFilters.java) representing all the filters which were passed back and forth between activities within the bundle.
• Nice job adding the share intent to the article detail view!
• Consider adding progress bars to your app whenever a network request goes out

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.