psecio / gatekeeper

Gatekeeper: An Authentication & Authorization Library
367 stars 23 forks source link

Improve the composer requirements to use ranges #34

Closed stof closed 9 years ago

stof commented 9 years ago

Using exact version constraints in requirements is a bad practice in libraries, because it makes them much harder to use: if the project does not use exactly that version of the library, it cannot use your library. And if it already uses your library, it cannot update the other one to benefit from a bug fix (or even potentially a security fix) until you make a new release compatible with it.

The worse requirement here was probably the symfony/expression-language one, as it was forcing to use an unmaintained version of Symfony to be compatible with your library.

enygma commented 9 years ago

Cool, thanks for the update - it's one of those things that was set during development and just never come back around to for investigation.

stof commented 9 years ago

@enygma I suggest you to update the robmorgan/phinx constraint too (composer validate should be complaining about your package btw)