search

psemiletov / drumlabooh

LV2/VSTi drum machine that can use Hydrogen, SFZ, and other drumkit formats
https://psemiletov.github.io/drumlabooh/
GNU General Public License v3.0
31 stars 1 forks source link

drum_sklad as a git submodule #9

Open trebmuh opened 2 months ago

trebmuh commented 2 months ago

Can you please make drum_sklad a git submodule that we can fetch with a git clone --recursive ? I'm trying to build a deb package for it and the build chroot doesn't have access to the internet (for security/reproducibility reasons).

(same for JUCE I guess)

psemiletov commented 2 months ago

Hello! Thank you for the feedback. But see the example of using fetch feature at Debian package: https://sources.debian.org/patches/faiss/1.7.4-3/0001-Use-system-GTest.patch/ The reason of fetch instead of git submodules was the github authorization - when I tried to use submodule, the build process requires for user to log in to the github. So I preferred FetchContent instead.