Layout in BODY tag not good practice

psergus / ngWYSIWYG

true angular WYSIWYG

MIT License

63 stars 42 forks source link

Layout in BODY tag not good practice #18

Closed eugenev3 closed 8 years ago

eugenev3 commented 9 years ago

This can cause global issues when compiling the CSS if using a CSS preprocessor such as SASS.

psergus commented 9 years ago

explain pls

eugenev3 commented 9 years ago

For anyone who wants to pull in ngWYSIWYG into their web app or web site, your BODY margin and padding definitions in editor.css can override their BODY styles. I don't think it is necessary in editor.css.

psergus commented 9 years ago

I see what you mean now. Completely agree. I just reworked styles to push them into the scope and avoid the space pollution. I also added sass file. Thx for your feedback. :+1:

brunokrebs commented 8 years ago

Issue solved? Maybe it is time to close it.

BTW: Sorry to keep bothering you @psergus, but I like this lib and I will be playing with it for a while.

psergus commented 8 years ago

closing it.