pserwylo / herri

"Find your place in your community" - A project for govhack.org 2014
1 stars 3 forks source link

Add attributions for all data used. #4

Open pserwylo opened 10 years ago

pserwylo commented 10 years ago

Leaflet.js has built in support for showing attributions. However it may be better to actually include it in the footer of the main page (or at least something linked to from the footer). That way, a more comprehensive discussion of the data being used can be made available.

Currently, there is:

I believe that is all, but I may be missing something

BenSpecht commented 10 years ago

Within the JSON data, is there anything in there that we could use as an attribution so we don't have to manually write it for each set of data?

pserwylo commented 10 years ago

Your general principle is good. We'd have to have a table in the database, and then build our own methods in django for retrieving that data. There may well be a way in the geoJSON spec for returning attributions for geographic data, but we'd also want to attribute arbitrary other data, for which relying on an existing spec like geoJSON is probably not worth it.

It is all part of the process of making it easier for admin users to import datasets without manually munging the data directly into the database. Think a form that says:

The whole process is quite large, but definitely worth it in the long run. In the mean time, perhaps staticly coding them in the template will suffice.

logworthy commented 10 years ago

We have the model in the Django database for Attributes. I think the purest approach would give Attributes a Table relation, and then Tables might have some attribution notes as a field -- or link to a Source object which had attribution notes. (Though we may want to review our architecture more holistically.. I might raise that as another issue.)

But yeah, I think just coding up a 'data sources' page is a good interim solution.