pserwylo / solitaire-for-android

Fork of https://code.google.com/p/solitaire-for-android, which has been inactive since 2010.
Apache License 2.0
1 stars 0 forks source link

Illegal moves allowed in Forty Thieves #8

Open JonnyTech opened 10 years ago

JonnyTech commented 10 years ago

Hi, I downloaded the app through f-droid: https://f-droid.org/repository/browse/?fdfilter=solitaire&fdid=com.kmagic.solitaire

There is a bug in Forty Thieves which allows one to move move cards than is actually allowed: ie, if there is one empty column then only one card should be able to be moved there but the game allows two.

I found a similar bug report here: http://code.google.com/p/solitaire-for-android/issues/detail?id=29

There is also a patch with the report which claims to fix the issue: http://code.google.com/p/solitaire-for-android/issues/attachmentText?id=29&aid=5110406154441661969&name=emptystackpatch.patch

Are you able to implement/include the fix?

pserwylo commented 10 years ago

Hi @JonnyTech. I'd still like to maintain this software at some point in the future, through this fork that you've found here. But to be realistic, I've got a few other projects that are taking priority. Perhaps sometime later in 2014 I'll get around to bringing this game up to scratch with modern phones (i.e. allow spider solitaire dealing on phones without a hardware "search" button, making high resolution graphics, etc). If this was to happen, I would definitely include the patch you linked to. In fact, I would probably go through issues on the original tracker again and see if there are other patches available.

As it currently stands, I'm not willing to publish my fork on F-Droid, as it is still buggy after all of the changes I made to support higher resolution graphics (I really should have done it in another branch - maybe I'll sort that out at a later date too, so that some bugs can be fixed, without having to worry about high resolution graphics).

Anyway, I'll let you know if I start working on this again.

Cheers, pete.