search

pseudoankit / coachmark

A lighweight compose multiplatform libray to create better onboarding experience for users.
Apache License 2.0
121 stars 8 forks source link

Could you please support jdk11？ #32

Open gitzhan opened 5 months ago

gitzhan commented 5 months ago

The current artifact supports only jdk17+，Could you please support jdk11？thanks！

pseudoankit commented 5 months ago

Library uses jdk 11 only, are you facing any issues? also the demo app uses jdk 8 and it works fine with the lib, what issue are facing while integrating?

gitzhan commented 5 months ago

I confirmed it again. 1、I'm just generating a new pure project from https://kmp.jetbrains.com/ (My project environment is jdk11) 2、Then,just add this dependency 3、Run the lib's demo in the main application function 4、after this,I received an error some screenshot show below: image image

pseudoankit commented 5 months ago

let me check this

pseudoankit commented 5 months ago

Did complete same steps able to run in desktop too 1 issue I faced with 1.8.0 is iosArm64 not present, can you try using version 1.7.1 and see if you are facing the issue meanwhile I am checking this issue the iosArm64 issue

Also can you please try to run in ios/android device?

gitzhan commented 5 months ago

sorry for this,my project is just for desktop/jvm. today,I took the time to download the source code here, and then use my environment to compile,it work well. My guess is that the project compilation or release scripts here are the reason why jdk11 is not supported

pseudoankit commented 5 months ago

yeah release flow uses jdk 17 but the library uses 11 only, did you tried the latest release 2.0.3, there was 1 issue I was using linux OS for release deployment so ios artifacts were not uploading changed to macOS not sure if this has anything do with your issue but just asking

I already did the complete same steps and I was able to use it desktop too

pseudoankit commented 5 months ago

Hey I tried again and it seems to work Created a KMP project from the template andorid/iOS/desktop/web added the library deps

Got a error related to WASM I have not supported this, so commented out wasmJs block synced and was able to run Got another issue that run button for desktop not working so ran the command to launch desktop ./gradlew :composeApp:run

Additionally can you please check your jdk in studio setting AndroidStudio -> Settings -> BuildsTools -> Gradle -> Gradle JDK (mine is to set to JBR 17)

and what is your java version mine is 20.0.1

gitzhan commented 5 months ago

My Gradle JVM is the same as the project SDK, which is JDK11(11.0.12). then I tried version 2.0.3 and it still told me that the project needed jdk17+ to work.

pseudoankit commented 5 months ago

@gitzhan did you tried with version I shared in last message still facing the issue, then can you please push the code and share me the repo will have a look