search

pseudomuto / protoc-gen-doc

Documentation generator plugin for Google Protocol Buffers
MIT License
2.64k stars 464 forks source link

Support for Oneof in proto files #362

Closed lpabon closed 2 years ago

lpabon commented 6 years ago

Also included a template to generate markdown from grpc proto spec

Signed-off-by: Luis Pabón luis@portworx.com

jason-fox commented 6 years ago

If this is a more up-to-date protokit compatible 1.1.0 compatible solution to fix the issue #333 I personally would love to see oneOf added.

I raised PR #336 for this problem back in January, and I have been awaiting feedback ever since. I have changed jobs in the last six months, and would no longer have time to commit to making further updates in Go to move my own PR forward, so assuming you are more active in the area I would like to see this effort move to a successful conclusion.

Does this also create a oneOf description from the comments as well as a flag? Do the templates need updating? Is there anything else you could amalgamate from my effort?

Globegitter commented 5 years ago

@pseudomuto anything blocking this from getting merged? Is it not compatible anymore with the latest version?

nicolassleiman commented 4 years ago

Any update?

guiguan commented 4 years ago

Yes, please merge this one

nielsvaneck commented 4 years ago

@pseudomuto could this be merged & released?

ping-localhost commented 4 years ago

Can we please get this merged @pseudomuto. Anything I can do to help?

ping-localhost commented 3 years ago

Pinging @pseudomuto again. Anything I/we can do to help?

pseudomuto commented 3 years ago

At a glance this LGTM 👍 At this point it'll need a rebase

ping-localhost commented 3 years ago

At a glance this LGTM 👍 At this point it'll need a rebase

Any chance you're able to do so @pseudomuto / @lpabon. Otherwise I'll take a crack at it :)

fhalim commented 3 years ago

Submitted https://github.com/pseudomuto/protoc-gen-doc/pull/436 to rebase this PR against current master.

lpabon commented 2 years ago

Hey guys! Just noticed this 4 years later now that I'm back on this again 😄 . Thank you so much for merging!