search

pseudomuto / protoc-gen-doc

Documentation generator plugin for Google Protocol Buffers
MIT License
2.59k stars 462 forks source link

Dockerhub's images contain the outdated protoc #464

Closed panter-dsd closed 2 years ago

panter-dsd commented 2 years ago 
docker run -ti --rm --entrypoint /bin/bash pseudomuto/protoc-gen-doc:1.5.0
root@e8426ffe2a09:/# protoc --version
libprotoc 3.6.1

But looks like it should be 3.18.1

obitech commented 2 years ago

+1 on this, I could really use the updated image!

xhanin commented 2 years ago

the Dockerfile has been updated on master branch but the updated docker image has not been published.

so as a workaround I cloned the repo and build the image myself:

git clone git@github.com:pseudomuto/protoc-gen-doc.git && cd protoc-gen-doc
docker build -t protoc-gen-doc .

then using this image protoc 3.18.1 is used and optional fields are accepted in proto3 syntax

davidjlynn commented 2 years ago

The version of protoc was bumped (to v3.18.1) in https://github.com/pseudomuto/protoc-gen-doc/commit/89d7d931fac2cf8a4f746406034298d1175105f0 This was included in the newest release v1.5.1. @panter-dsd / @pseudomuto This issue can be closed.