search

pseudomuto / protoc-gen-doc

Documentation generator plugin for Google Protocol Buffers
MIT License
2.59k stars 462 forks source link

Update Masterminds/sprig dependency to fix CamelCase to snake_case conversion bug in xstrings #528

Closed jpihl closed 3 weeks ago

jpihl commented 4 months ago

What is Changing?

I propose updating the Masterminds/sprig dependency to address a bug where text with numbers would not be correctly converted from CamelCase to snake_case. This bug is located in the version of huandu/xstrings library used by the current version of Masterminds/sprig.

How is it Changing?

The version of sprig will be updated from v2.15.0 to version v2.22.0, which in turn will update xstrings from v1.0.0 to v1.4.0.

The update was done by executing the following commands:

go get -u github.com/Masterminds/sprig
go mod tidy -go=1.16 && go mod tidy -go=1.17

What Could Go Wrong?

The changes have been tested locally to ensure compatibility and correctness. The risk of merging these changes is minimal, as it primarily involves updating a dependency to fix a specific issue.

@pseudomuto

pseudomuto commented 3 weeks ago

This LGTM 👍 Thanks so much for the addition!