data_dragon.versions_for_region not working with eun1 and oc1

pseudonym117 / Riot-Watcher

Simple Python wrapper for the Riot Games API for League of Legends

MIT License

532 stars 150 forks source link

data_dragon.versions_for_region not working with eun1 and oc1 #165

Closed Buksii1449 closed 3 years ago

Buksii1449 commented 4 years ago

Almost all Riot APIs use "EUN1" as the platform keyword for EUNE, but datadragon is an expection, it uses "EUNE". You can still use .versions_for_region("EUNE"), but the example code and the documentation doesn't mention this anywhere. (The same happens with OC1/OCE)

pseudonym117 commented 3 years ago

This is kinda just riots fault. I'll try adding to the readme, but cant be sure it will stay up to date, as riot seems allergic to consistency...

pseudonym117 commented 3 years ago

Added to readme in #196